Problem with button not working

[randyriegel]

I am converting a friends website from a frame based site to a frameless site. There are buttons on the available properties page that call a javascript function to show a google map of the location. I have all the javascript code the same as the old site but for some reason the button is not working on the new one. I know it's gotta be something real stupid. Maybe someone can take a fresh look at it for me... I've been looking at it for hours and I'm about ready to go crazy.

The new site is:

http://zimprops.com/?page=available

The old page is:

http://dev.zimprops.com/availprops2.php

I moved the old site to my development subdomain just so I had something to go by. Any help would be great.

[Vin DSL]

Hrm...

Taking a quick peek - shouldn't that first instance of mapbutton22 be wrapped in single quotes?

EDIT

First instance of mapbutton18 too.

I see the beginning quote only...

function showMap22() { 
alert('Got here!');if (document.getElementById('mapbutton22).value=='Show Map') {
document.getElementById('mapbutton22').value='Hide Map';
document.getElementById('map22').style.display = 'block';
var map22 = new google.maps.Map2(document.getElementById('map22'));
map22.setCenter(new google.maps.LatLng(40.3690599,-80.6234779), 15);
var point = new GLatLng(40.3690599,-80.6234779);
map22.addOverlay(new GMarker(point));
map22.mapResize();
} else {
document.getElementById('mapbutton22').value='Show Map';
document.getElementById('map22').style.display = 'none';
}
}
function showMap18() { 
alert('Got here!');if (document.getElementById('mapbutton18).value=='Show Map') {
document.getElementById('mapbutton18').value='Hide Map';
document.getElementById('map18').style.display = 'block';
var map18 = new google.maps.Map2(document.getElementById('map18'));
map18.setCenter(new google.maps.LatLng(40.3690457,-80.6245213), 15);
var point = new GLatLng(40.3690457,-80.6245213);
map18.addOverlay(new GMarker(point));
map18.mapResize();
} else {
document.getElementById('mapbutton18').value='Show Map';
document.getElementById('map18').style.display = 'none';
}
}
</script>

Put another way:

Shouldn't...

alert('Got here!');if (document.getElementById('mapbuttonXX).value=='Show Map')

...actually be?

alert('Got here!');if (document.getElementById('mapbuttonXX').value=='Show Map')

[randyriegel]

Thanks that was it. Can't believe I missed that. All the Javascript is created dynamically by PHP depending on which rentals are available. That's why it was like that in both place.

Thanks again for your help!!

Randy

[Don McLeod]

In addition to what Vin DSL explained about the missing quote, I noticed that the two blocks of javascript are not exactly the same. Perhaps you could simply copy the block of code from the working file and see if it works in the new file? (never mind - I can see your recent post, and the problem is fixed)

Comment about the images - the page would really benefit from having actual 50x50 thumbnails linked to larger images rather than just using:

width='50' height='50'

The first time I visited your web pages they took a long time to load on a moderate speed DSL connection.

[randyriegel]

Good point Don. I've noticed that too and haven't addressed it yet. I'll probably use a php script to create the thumbnails on the fly.

Randy