Perl system() command not working

[tigertom]

When I try to get the Perl script I'm writing to do the following, the "Can't make new image" message comes up:

system("cp $path_to_template_directory/$template_gif $path_to_output_directory/$new_image") or die "Can't make new image $new_image : $!";

The paths and image names are correct.
Nothing shows up in the error log.
The output directory is chmoded to 707.

Does JagPc allow scripts to run system commands?

[mattsiegman]

try using bickticks instead --> `

[tigertom]

try using bickticks instead --> `

I did:

$cp_result = `cp "$path_to_template_directory/$template_gif $path_to_output_directory/$new_image"`;
print $cp_result;

This gave the error: 'missing destination file'

$template_gif exists.
$new_image is the one I'm tying to create.

What could be the problem?

Clues: The script does make one copy of the image, but fails to do so on subsequent passes (loops). It reports the error on all passes, even the first one.

[Spathiphyllum]

Quick and dirty, try:

#!/usr/bin/perl
#
#--------------------------------------------------
# cpfile.pl [9/14/2004 7:06:33 AM]
# Script to copy file
#--------------------------------------------------

use strict;
use warnings;

# Variables
my $temppath = '/absolute/path/to/template/dir';
my $tempfile = 'template.gif';
my $output_d = '/absolute/path/to/template/dir/output';
my $newimage = 'newpic.gif';

# Output directory (chmod 755) MUST exist; if it
# doesn't you may need a mkdir or an if exists loop

system(`cp $temppath/$tempfile $output_d/$newimage`)
 or die "Cannot make new image $newimage : $!";

print "$newimage created";

exit;

Don't know what parts you need but system calls work just fine. I think the syntax for cp is your main concern. This script fails under taint (you do use taint, right?) but there's not much point untainting this snippet unless you post all your code. Then the fees for assistance are no longer free.

[tigertom]

God bless you sir! It WAS the syntax of cp what was the problem:

It should have read:

$cp_result = `cp $path_to_template_directory/$template_gif $path_to_output_directory/$new_image`;

i.e. no quotation marks. Arrrgh!

Thanks again

[Spathiphyllum]

You're welcome. Matt gets partial credit in spite of his verbosity.