[chinna]

hi

iam new php, now i want write a html form datas to Excel file, for that i wrote following code, but it displaying errors like "Warning: Cannot modify header information - headers already sent by (output started at c:\program files\apache group\Apache\htdocs\sample\excel.php:9) in c:\program files\apache group\Apache\htdocs\sample\excel.php on line 56".


Code :


<?php

$db=mysql_connect('localhost', 'root', 'success');
if(!$db)
{
echo "error in connecting.............";
}
mysql_select_db('byt');
$result = mysql_query('select * from users');
$count = mysql_num_fields($result);

for ($i = 0; $i < $count; $i++){
$header .= mysql_field_name($result, $i)."\t";
}

while($row = mysql_fetch_row($result)){
$line = '';
foreach($row as $value){
if(!isset($value) || $value == ""){
$value = "\t";
}else{
$value = str_replace('"', '""', $value);
$value = '"' . $value . '"' . "\t";
}
$line .= $value;
}
$data .= trim($line)."\n";
}
$data = str_replace("\r", "", $data);


if ($data == "") {
$data = "\nno matching records found\n";
}

header('Content-type: application/octet-stream');

header('Content-Disposition: attachment; filename=excelfile.xls');
header('Pragma: no-cache');
header("Expires: 0");

echo $header."\n".$data;
?>


whats the wrong with code.....

pls help me its urgent task for me

Regards
Chinna

[the_ancient]

the only thing I see right off is

if(!$db)
{
echo "error in connecting.............";'
}

If you get a Db error here it will throw the echo statment and then try to pass header info which will not be allowed as the headers are sent BEFORE the text

Change it to

if(!$db)
{
echo "error in connecting.............";'
die();
}

Or you can use

if(!$db)
{
echo "error in connecting.............";'

}else{

making sure to add another "}" at the end of the code

[mattsiegman]

also, it will break if you have any space before your <?

[Vin DSL]

Pretty self-explanatory! You're calling the header twice and that's a no-no...

Comment out one of those lines, and it should take care of itself.

[Ron]

Use the php tags around php code in the forum please...

PHP Code:

<?php

$db=mysql_connect('localhost', 'root', 'success');
if(!$db)
{
    echo "error in connecting.............";
            die(mysql_error());
}
if (! mysql_select_db('byt'))
{
            die(mysql_error());
}
if (! $result = mysql_query('select * from users'))
{
            die(mysql_error());
}

$count = mysql_num_fields($result);

for ($i = 0; $i < $count; $i++){
    $header .= mysql_field_name($result, $i)."\t";
}

while($row = mysql_fetch_row($result)){
  $line = '';
  foreach($row as $value){
    if(!isset($value) || $value == ""){
      $value = "\t";
    }else{
      $value = str_replace('"', '""', $value);
      $value = '"' . $value . '"' . "\t";
    }
    $line .= $value;
  }
  $data .= trim($line)."\n";
}
  $data = str_replace("\r", "", $data);


if ($data == "") {
  $data = "\nno matching records found\n";
}

header('Content-type: application/octet-stream');

header('Content-Disposition: attachment; filename=excelfile.xls');
header('Pragma: no-cache');
header("Expires: 0");

echo $header."\n".$data;
?>

I think your error is in your mysql_query() call... because the error message says that headers were output on line 9 of your code.

What is happening is that the error or warning itself is sending output and headers. You can shut off warnings and error output, but you'll have to fix the errors anyway.

Try adding the lines as I suggest in your code above.

Good luck.

[the_ancient]

Originally Posted by Ron

Use the php tags around php code in the forum please...
.

yes dad

[Ron]

[code] Tags are ok, too...

[chinna]

thanks for replyed, i tryed the above suggestions but still iam getting same errors...

Regards
Chinna

[Ron]

No way, unless this code is being called from another program. The line number in the error would change at a minimum.

[chinna]

the following code also displaying Warning: Cannot modify header information - headers already sent by

<?php
header('Location: http://www.example.com/');
?>

is there any specific configuration in php.ini to use "header"?..

Regards
Chinna

[Vin DSL]

Originally Posted by chinna

is there any specific configuration in php.ini to use "header"?...

Hrm...

That's a thought!

You might try adding or changing the state of:

output_buffering=on;

[the_ancient]

Originally Posted by chinna

the following code also displaying Warning: Cannot modify header information - headers already sent by

PHP Code:

<?php
header('Location: http://www.example.com/');
?>

is there any specific configuration in php.ini to use "header"?..

Regards
Chinna

In addition to vins suggestion make sure:

Originally Posted by mattsiegman

also, it will break if you have any space before your <?

you can not send ANYTHING at all before you send header, no html, no text, NOTHING.

Make sure your not

[Ron]

hmmmmmm

I don't think a space before <? will cause this problem inside a .php file; perhaps in a .html file.... OR if he's got a handler set to handle .php as parsed .html?

How is this code being called? Straight from a URL or from another script?

[chinna]

thanks thanks a lot i found a error... its the space before <?php ..now working properly....thanks ron .. i will meet with next problem..

best reagrds
Chinna

[the_ancient]

Originally Posted by Ron

hmmmmmm

I don't think a space before <? will cause this problem inside a .php file; perhaps in a .html file.... OR if he's got a handler set to handle .php as parsed .html?

How is this code being called? Straight from a URL or from another script?

yes it will, anything outside, even a single space, of the <? ?> tages is sent to the browser which means the headers where also sent,

Test it...